Changed headless mode to a flag instead of env variable #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also in the methods.go file, when I forked it for some reason it was importing strconv but it's never used so it errors out. For my own testing I just commented it out but I left it in for the merge in case it's something that is necessary. |
jpahm
requested changes
Oct 20, 2024
jpahm
approved these changes
Oct 22, 2024
jpahm
reviewed
Oct 22, 2024
| @@ -20,7 +20,7 @@ import ( | |||
| func ScrapeCoursebook(term string, startPrefix string, outDir string) { | |||
|
|
|||
| // Load env vars | |||
| if err := godotenv.Load(); err != nil { | |||
| if err := godotenv.Load(".env.template"); err != nil { | |||
There was a problem hiding this comment.
There is actually an error here I noticed after-the-fact (which I've fixed via da5bab6); this shouldn't be changed to read from .env.template since the template file is only used as a basis for creating an actual .env file (which is what this loads from by default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made headless mode into a global variable in methods.go so that the InitChromeDp() method is able to use it. If we want to protect the variable more instead of being able to just change the value at anytime, we can make it a private variable and just make a setter method.