add tests for approving, denying PI membership requests #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds tests for approving and denying PI membership requests while updating the GitHub workflows to ensure submodules are checked out during CI runs.
- Added "with: submodules: true" lines in pre-commit, phpunit, and functional workflows to support projects that use submodules.
Reviewed Changes
Copilot reviewed 5 out of 21 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/pre-commit.yml | Enables checkout of submodules |
| .github/workflows/phpunit.yml | Enables checkout of submodules |
| .github/workflows/functional.yml | Enables checkout of submodules for functional tests |
Files not reviewed (16)
- .gitmodules: Language not supported
- composer.json: Language not supported
- resources/autoload.php: Language not supported
- resources/lib/UnityGroup.php: Language not supported
- resources/lib/UnityLDAP.php: Language not supported
- resources/lib/UnityOrg.php: Language not supported
- resources/lib/UnityUser.php: Language not supported
- test/functional/LoginShellSetTest.php: Language not supported
- test/functional/PiMemberApproveTest.php: Language not supported
- test/functional/PiMemberDenyTest.php: Language not supported
- test/functional/PiRemoveUserTest.php: Language not supported
- test/phpunit-bootstrap.php: Language not supported
- test/unit/AjaxSshValidateTest.php: Language not supported
- test/unit/UnityGithubTest.php: Language not supported
- tools/docker-dev/sql/bootstrap-users.sql: Language not supported
- tools/docker-dev/unity-web-portal: Language not supported
simonLeary42
force-pushed
the
testing6
branch
3 times, most recently
from
7d2d6dc to
4171c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnityLDAPto use$this->getEntryto take advantage of prevent duplicate LDAPEntries hakasapl/phpopenldaper#7UnityGroup::approveUserwill work even if there was no request to approve