Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: add vkui-vite-ts example #8402

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

tech: add vkui-vite-ts example #8402

wants to merge 17 commits into from

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Mar 25, 2025 •
edited
Loading

  • Release notes

Описание

Необходимо добавить шаблон для приложения с использованием Vite + VKUI + TypeScript, чтобы пользователям было удобнее начинать использовать VKUI

Изменения

  • Добавил шаблон для приложения Vite + VKUI + TypeScript с небольшой версткой и возможностью изменения цветовой схемы приложения
  • Добавил Readme с документацией по шаблону

Проект можно глянуть через CodeSandbox

Release notes

Документация

  • Добавлен шаблон приложения на Vite + VKUI + TypeScript

@EldarMuhamethanov EldarMuhamethanov self-assigned this Mar 25, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner March 25, 2025 16:02
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 25, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@EldarMuhamethanov EldarMuhamethanov moved this to 👀 In Review in VKUI Mar 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 403.17 KB (0%)
JS (gzip) 119.85 KB (0%)
JS (brotli) 98.5 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.95 KB (0%)
CSS (gzip) 43.23 KB (0%)
CSS (brotli) 34.49 KB (0%)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

👀 Docs deployed

Commit c9e976c

inomdzhon
inomdzhon reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну огнивое 🔥

stackblitz работает шустрее, заметил – можно его первым в списке указать

@inomdzhon inomdzhon mentioned this pull request Mar 28, 2025
Open
1 task
@inomdzhon inomdzhon changed the title tech: add vkui-vite-ts example tech: add vkui-vite-ts example Mar 31, 2025
inomdzhon
inomdzhon reviewed Mar 31, 2025
View reviewed changes
inomdzhon
inomdzhon previously approved these changes Mar 31, 2025
View reviewed changes
inomdzhon
inomdzhon previously approved these changes Mar 31, 2025
View reviewed changes
BlackySoul
BlackySoul reviewed Apr 1, 2025
View reviewed changes
examples/vkui-vite-ts/index.html
<html lang="ru">
<head>
<meta charset="utf-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут мета-тэг наш потерялся? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, добавил

BlackySoul
BlackySoul reviewed Apr 1, 2025
View reviewed changes
examples/vkui-vite-ts/src/App.tsx
<Headline inline>
<Icon24LightbulbOutline className={styles.tipIcon} />
{'Совет: посмотрите другие '}
<Link href="https://vkcom.github.io/VKUI/">шаблоны</Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут точно такая ссылка?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вообще нет, просто я думал здесь оставить ссылку на шаблоны в доке. Но пока такой страницы нет

@BlackySoul
Copy link
Contributor

Вообще сомнительно, конечно, что мы форсим yarn в качестве сборщика
Кажется, дефолт это npm 🙃

@inomdzhon
Copy link
Contributor

Вообще сомнительно, конечно, что мы форсим yarn в качестве сборщика Кажется, дефолт это npm 🙃

пропагандируем Yarn, так как сами юзаем его 😎

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Apr 9, 2025
@BlackySoul BlackySoul added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Apr 9, 2025
@SevereCloud SevereCloud requested a review from BlackySoul April 10, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@BlackySoul BlackySoul Awaiting requested review from BlackySoul

At least 2 approving reviews are required to merge this pull request.

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
no-stale Добавляет PR в исключения для автоматического закрытия technical task
Projects
VKUI
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EldarMuhamethanov @BlackySoul @inomdzhon @vkcom-publisher