Repository navigation
Declare actionview as explicit gem dependency - #2461
Merged
Merged
Conversation
mikz
force-pushed
the
patch-1
branch
2 times, most recently
from
October 17, 2025 09:10
27bd6b5 to
a855b91
Compare
6 tasks done
mikz
force-pushed
the
patch-1
branch
2 times, most recently
from
October 18, 2025 05:26
cbe5826 to
61f920e
Compare
Spone
reviewed
Oct 20, 2025
Spone
self-requested a review
October 22, 2025 22:36
Spone
approved these changes
Oct 22, 2025
Contributor
Author
|
I’ll resolve the conflict later today and use a variable for the shared version constraint with activesupport. |
Spone
approved these changes
Oct 23, 2025
Contributor
Author
|
I see some issues with the lock files. Will regenerate then later today. |
lib/view_component.rb has `require "action_view"`, yet this gem did not have actionview declared as a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/view_component.rb has
require "action_view", yet this gem did not have actionview declared as a dependency.What are you trying to accomplish?
Gems depending on
view_componentwould need to declare own dependency on actionview and copy the required version.This PR tries to reduce the work and duplication by gem maintainers by delegating the responsibility here.