-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: turn off earth state panel #1349
Conversation
earth & cetus timers merged in 38.5.0
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes in this pull request adjust the rendering logic within the Changes
Sequence Diagram(s)sequenceDiagram
participant Panel as AggregatedTimePanel
participant Timer as EarthTimer
Panel->>Panel: Evaluate this.componentState.earth.display
Panel--)Panel: Condition returns false
Panel->>Timer: Do not render EarthTimer
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables the EarthTimer display in the aggregated time panel as part of the recent bug fixes for the time panel display.
- Disables EarthTimer by replacing its conditional check with a literal false value.
- Maintains the display logic for CetusTimer, VallisTimer, and CambionTimer.
## [2.5.4](v2.5.3...v2.5.4) (2025-03-30) ### Bug Fixes * turn off earth state panel ([#1349](#1349)) ([37c696a](37c696a))
🎉 This PR is included in version 2.5.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary:
earth & cetus timers merged in 38.5.0
Fixes issue (include link):
Mockups, screenshots, evidence:
Summary by CodeRabbit