[AIE2][AIE2P] Add combiners related to extract/insert/broadcast #723
+902
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
andcarminati
force-pushed
the
andreu.extract.insert.postlegalizer
branch
2 times, most recently
from
78a35a0 to
595cb40
Compare
| combine_extract_concat, | ||
| combine_unmerge_concat, | ||
| combine_upd_to_concat, | ||
| combine_upd_to_concat, |
Collaborator
There was a problem hiding this comment.
whitespace change?
Collaborator
Author
There was a problem hiding this comment.
Yeah, I removed one unnecessary space after...
Collaborator
There was a problem hiding this comment.
have you guys figured out how to run clang format on td files?
Collaborator
Author
There was a problem hiding this comment.
No, sorry! I just saw this space and deleted it....
|
|
||
| // Check that the insert source vector is G_IMPLICIT_DEF | ||
| const MachineInstr *InsertSrcMI = MRI.getVRegDef(InsertSrcVecReg); | ||
| if (!InsertSrcMI || InsertSrcMI->getOpcode() != TargetOpcode::G_IMPLICIT_DEF) |
Collaborator
There was a problem hiding this comment.
Oh, I have been using broadcast instead of insert into implicit def for the FMUL implementation. It will not work there.
Collaborator
Author
There was a problem hiding this comment.
Humm, I was working on the FADD mir. It looks we use different approaches in different legalizations.
…x), index) into copy Postlegalizer combiner that matches a pattern where: %18:_(<16 x s32>) = COPY $x0 %10:_(<16 x s32>) = G_IMPLICIT_DEF %9:_(s32) = G_CONSTANT i32 0 %8:_(s32) = G_AIE_SEXT_EXTRACT_VECTOR_ELT %18(<16 x s32>), %9(s32) %22:_(<16 x s32>) = G_AIE_INSERT_VECTOR_ELT %10, %8(s32), %9(s32) And turns it into: %22:_(<16 x s32>) = COPY %18
This patch adds a new postlegalizer combiner that optimizes patterns where an element is extracted from position 0, broadcast to a vector, and then only position 0 is used through a chain of operations. Pattern optimized: %extract = G_AIE_SEXT_EXTRACT_VECTOR_ELT %src(<N x T>), 0 %broadcast = G_AIE_BROADCAST_VECTOR %extract ... (chain of concat/unmerge/vector ops) %result = G_AIE_SEXT_EXTRACT_VECTOR_ELT %final, 0 Transforms to: %extract = G_AIE_SEXT_EXTRACT_VECTOR_ELT %src(<N x T>), 0 %broadcast = COPY %src // Broadcast eliminated! ... (chain of operations) %result = G_AIE_SEXT_EXTRACT_VECTOR_ELT %final, 0 The combiner uses a conservative whitelist approach to verify that operations in the chain don't shift vector elements. It handles: - G_CONCAT_VECTORS (broadcast must be first operand) - G_UNMERGE_VALUES (only first output used, others dead) - Whitelisted operations: G_FADD, G_FMUL, G_FSUB, and specific AIE2P intrinsics - Rejects: G_BITCAST, type mismatches, non-zero extracts, multiple uses This optimization is particularly beneficial when broadcasts are used unnecessarily when only the first element is needed. The combiner runs as a postlegalizer custom combiner for both AIE2 and AIE2P.
andcarminati
force-pushed
the
andreu.extract.insert.postlegalizer
branch
from
595cb40 to
36316a6
Compare
andcarminati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x), index) into copy
Postlegalizer combiner that matches a pattern where:
%18:(<16 x s32>) = COPY $x0
%10:(<16 x s32>) = G_IMPLICIT_DEF
%9:(s32) = G_CONSTANT i32 0
%8:(s32) = G_AIE_SEXT_EXTRACT_VECTOR_ELT %18(<16 x s32>), %9(s32)
%22:_(<16 x s32>) = G_AIE_INSERT_VECTOR_ELT %10, %8(s32), %9(s32)
And turns it into:
%22:_(<16 x s32>) = COPY %18
FYI @martien-de-jong.