Skip to content

fix(activate): target title-bar commands to their click-origin instance #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
easonLiangWorldedtech wants to merge 30 commits into
base: main
Choose a base branch
from
Open

fix(activate): target title-bar commands to their click-origin instance #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3396c9e
fix(activate): target title-bar commands to their click-origin instance
easonliang28 Sep 4, 2026
a143267
ci: re-trigger PR review-state labeler reconciliation (no-op commit)
easonliang28 Sep 7, 2026
723d871
fix(activate): serialize overlapping openClineInNewTab calls and hard…
easonliang28 Sep 7, 2026
c3027c8
test(activate): pin openClineInNewTab creation branches and strengthe…
easonliang28 Sep 7, 2026
00eb15f
fix(activate): harden tab creation serialization and centralize title…
easonliang28 Sep 7, 2026
ae038ab
test(activate): pin tracked tab identity against the created panel
easonliang28 Sep 7, 2026
99662bd
test(activate): pin the tracked tab panel passed to getInstanceForView
easonliang28 Sep 7, 2026
6c5d54e
chore(vps2-f0): re-stack F0 onto upstream/main 7c291bb08
easonliang28 Sep 28, 2026
f94a8a6
Merge branch 'main' into vps2/f0-button-targeting
easonLiangWorldedtech Oct 5, 2026
56542c5
Merge upstream/main into vps2/f0-button-targeting
Oct 7, 2026
9b0d897
test(activate): pass the focus tracker to the tab-creation tests
Oct 7, 2026
faa5fd7
Merge upstream/main into vps2/f0-button-targeting
Oct 7, 2026
bc39e81
fix(activate): focus the provider focusPanel selects, and never hand …
Oct 8, 2026
08225f5
fix(activate): scope palette commands to their surface and pin the fo…
easonliang28 Oct 13, 2026
6a7ae11
style(activate): bring the touched files under the repo format gate
easonliang28 Oct 13, 2026
f8dde3e
Merge upstream/main (4f1dee18e) into vps2/f0-button-targeting
easonLiangWorldedtech Oct 16, 2026
a088195
fix(activate): keep the tracked surface live across resolutions and d…
easonLiangWorldedtech Oct 22, 2026
219572f
chore(knip): mark the test-only getPanel seam @internal
easonLiangWorldedtech Oct 22, 2026
16522b6
fix(webview): scope sidebar listener disposal to the disposed view
easonLiangWorldedtech Oct 22, 2026
e931e35
test(webview): type the replacement-view double without an explicit any
easonLiangWorldedtech Oct 22, 2026
2597a1b
fix(webview): ignore undefined disposables from view doubles
easonLiangWorldedtech Oct 22, 2026
fc1614d
test(activate): cover the focusPanel command negative path
easonLiangWorldedtech Oct 22, 2026
cb25147
Merge upstream/main into vps2/f0-button-targeting
Nov 1, 2026
8e03755
fix(merge): restore the upstream hunks dropped by the main merge
easonLiangWorldedtech Nov 1, 2026
f61e069
chore(lint): normalize eslint-suppressions.json formatting
easonLiangWorldedtech Nov 1, 2026
3eb0556
merge upstream/main (a4f774b17) into vps2/f0-button-targeting
easonLiangWorldedtech Nov 2, 2026
2860e2b
fix(commands): type the command callback args without any
easonLiangWorldedtech Nov 2, 2026
f1105fd
test(activate): keep the diagnostics command wired to the arguments i…
easonLiangWorldedtech Nov 4, 2026
5e44ab0
refactor(webview): drop the per-surface disposable map that nothing r…
easonLiangWorldedtech Nov 4, 2026
e4b3151
test(webview): pin the tab panel's listener tracking as well
easonLiangWorldedtech Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/types/src/vscode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ export const commandIds = [
"popoutButtonClicked",
"settingsButtonClicked",

// Editor-tab (popped-out) surface variants of the title-bar buttons. The
// shared ids above target the sidebar click origin, so the tab surface
// needs its own ids (see registerCommands.ts getTabProvider).
"plusButtonClickedInTab",
"settingsButtonClickedInTab",
"marketplaceButtonClickedInTab",
"historyButtonClickedInTab",

"openInNewTab",

"newTask",
Expand Down
Loading
Loading