feat(chart)!: change default service type to ClusterIP#661
Open
CatherineThompson wants to merge 1 commit intoacryldata:masterfrom
Open
feat(chart)!: change default service type to ClusterIP#661CatherineThompson wants to merge 1 commit intoacryldata:masterfrom
CatherineThompson wants to merge 1 commit intoacryldata:masterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
CatherineThompson
force-pushed
the
ct-service-type
branch
from
51d594a to
a83aa58
Compare
default datahub-frontend and datahub-gms to ClusterIP for better security. this prevents unintentional public exposure on initial deployment. BREAKING CHANGE: the default service type is no longer LoadBalancer. users requiring external access must now explicitly set service.type to LoadBalancer or configure an Ingress. Closes acryldata#659
CatherineThompson
force-pushed
the
ct-service-type
branch
from
a83aa58 to
27903be
Compare
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default datahub-frontend and datahub-gms to ClusterIP for better security. this prevents unintentional public exposure on initial deployment.
BREAKING CHANGE: the default service type is no longer LoadBalancer. users requiring external access must now explicitly set service.type to LoadBalancer or configure an Ingress.
Closes #659
Checklist
Note
Medium Risk
Breaking Helm chart default: new installs will no longer create external
LoadBalancerservices for GMS/frontend, which can surprise users relying on automatic public exposure. Change is configuration-only but affects networking/accessibility on upgrade or fresh deploys.Overview
Changes the default Kubernetes Service type for
datahub-gmsanddatahub-frontendfromLoadBalancertoClusterIP, reducing accidental public exposure and requiring users to explicitly opt intoLoadBalanceror use Ingress for external access.Bumps the parent chart version to
0.9.0and updatesdatahub-gms/datahub-frontendsubchart versions to0.4.0, plus updates the values reference and subchart READMEs to reflect the new defaults.Written by Cursor Bugbot for commit a83aa58. This will update automatically on new commits. Configure here.