Skip to content

feat(chart)!: change default service type to ClusterIP #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CatherineThompson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(chart)!: change default service type to ClusterIP #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/datahub/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ description: A Helm chart for DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.8.21
version: 0.9.0
Comment thread
cursor[bot] marked this conversation as resolved.

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v1.4.0.3
dependencies:
- name: datahub-gms
version: 0.3.5
version: 0.4.0
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.3.2
version: 0.4.0
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
Expand Down
4 changes: 2 additions & 2 deletions charts/datahub/VALUES_REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,7 @@ This document provides a comprehensive reference for every single configurable v
<tr>
<td><code>datahub-gms.service.type</code></td>
<td>string</td>
<td><code>LoadBalancer</code></td>
<td><code>ClusterIP</code></td>
Comment thread
cursor[bot] marked this conversation as resolved.
<td>Service type for GMS (LoadBalancer, ClusterIP, or NodePort).</td>
</tr>
<tr>
Expand Down Expand Up @@ -1298,7 +1298,7 @@ This document provides a comprehensive reference for every single configurable v
<tr>
<td><code>datahub-frontend.service.type</code></td>
<td>string</td>
<td><code>LoadBalancer</code></td>
<td><code>ClusterIP</code></td>
<td>Service type for frontend (LoadBalancer, ClusterIP, or NodePort).</td>
</tr>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.3.2
version: 0.4.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v1.3.0
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Current chart version is `0.2.163`
| securityContext | object | `{}` | |
| service.port | int | `9001` | |
| service.nodePort | int | `""` | |
| service.type | string | `"LoadBalancer"` | |
| service.type | string | `"ClusterIP"` | |
| service.extraLabels | object | `{}` | |
| serviceAccount.annotations | object | `{}` | |
| serviceAccount.create | bool | `true` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ securityContext: {}
priorityClassName:

service:
type: LoadBalancer # ClusterIP or NodePort
type: ClusterIP # LoadBalancer, ClusterIP or NodePort
port: 9002
targetPort: http
containerPort: 9002
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for DataHub's datahub-gms component
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.3.5
version: 0.4.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v1.15.0
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Current chart version is `0.2.176`
| resources | object | `{}` | |
| securityContext | object | `{}` | |
| service.port | int | `8080` | |
| service.type | string | `"LoadBalancer"` | |
| service.type | string | `"ClusterIP"` | |
| serviceAccount.annotations | object | `{}` | |
| serviceAccount.create | bool | `true` | |
| serviceAccount.name | string | `nil` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ securityContext: {}
priorityClassName:

service:
type: LoadBalancer # ClusterIP or NodePort
type: ClusterIP # LoadBalancer or NodePort
# Defines if NodePorts will be automatically allocated for services
# with type LoadBalancer. It may be set to "false" if the cluster load-balancer
# does not rely on NodePorts.
Expand Down
4 changes: 2 additions & 2 deletions charts/datahub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ datahub-gms:
enabled: true
default: true
toggeable: true
# Optionaly specify service type for datahub-gms: LoadBalancer, ClusterIP or NodePort, by default: LoadBalancer
# Optionaly specify service type for datahub-gms: LoadBalancer, ClusterIP or NodePort, by default: ClusterIP
# service:
# type: ClusterIP
# Load balancer class for datahub-gms. Used by cloud providers to select a load balancer implementation other than the cloud provider default.
Expand Down Expand Up @@ -99,7 +99,7 @@ datahub-frontend:
# initialViewer:manualPassword
service:
extraLabels: {}
# Optionaly specify service type for datahub-frontend: LoadBalancer, ClusterIP or NodePort, by default: LoadBalancer
# Optionaly specify service type for datahub-frontend: LoadBalancer, ClusterIP or NodePort, by default: ClusterIP
# type: ClusterIP

acryl-datahub-actions:
Expand Down