fix(actions): fix extraVolumes template rendering in actions subchart#676
Merged
pedro93 merged 2 commits intoacryldata:masterfrom Mar 17, 2026
Merged
Conversation
Standardize the extraVolumes template block to use `{{- with }}` instead
of `{{- if }}` and add `{{-` trim marker, matching the pattern used in
datahub-gms and datahub-frontend subcharts. Also add example comments
to values.yaml for discoverability.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- acryl-datahub-actions subchart: 0.3.2 -> 0.3.3 - datahub parent chart: 0.8.21 -> 0.8.22 - Update actions dependency version in parent Chart.yaml Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
anshbansal
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraVolumestemplate block inacryl-datahub-actionsto use{{- with }}instead of{{- if }}, matching the pattern used indatahub-gmsanddatahub-frontendsubcharts{{-trim marker to prevent spurious whitespace in rendered outputvalues.yamlfor discoverability (matching gms/frontend)Motivation
When using
extraVolumesto mount a tmpfs for ingestion venvs (/tmp/datahub), the old{{- if }}pattern with missing trim marker produced extra whitespace. The{{- with }}pattern is already used consistently in the other subcharts.Test plan
helm templaterenders correctly withextraVolumesset (emptyDir tmpfs)helm templaterenders correctly with default emptyextraVolumes🤖 Generated with Claude Code