Skip to content

Remove unused parameters from private load method#200

Draft
Copilot wants to merge 2 commits into
chore/change_deprecated_icon_methodfrom
copilot/sub-pr-199
Draft

Remove unused parameters from private load method#200
Copilot wants to merge 2 commits into
chore/change_deprecated_icon_methodfrom
copilot/sub-pr-199

Conversation

Copilot AI commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Addresses review feedback to simplify the private load method signature in SarifFileType.kt.

Changes

  • Removed unused cacheKey and flags parameters from load method
  • Updated single call site to pass only the required path parameter

Before:

override fun getIcon(): Icon = load("com.github.adrienpessu.sarifviewer/sarif.svg", -2129886975, 0);

private fun load(path: String, cacheKey: Int, flags: Int): Icon {
    return IconLoader.getIcon(path, SarifFileType::class.java.classLoader)
}

After:

override fun getIcon(): Icon = load("com.github.adrienpessu.sarifviewer/sarif.svg")

private fun load(path: String): Icon {
    return IconLoader.getIcon(path, SarifFileType::class.java.classLoader)
}

This eliminates unused-parameter inspection warnings and clarifies the method's actual requirements.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: adrienpessu <7055334+adrienpessu@users.noreply.github.com>

Copilot AI commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.jetbrains.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:&#43;HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update IconManager to IconLoader based on feedback Remove unused parameters from private load method Feb 16, 2026
Copilot AI requested a review from adrienpessu February 16, 2026 14:54
@felickz felickz marked this pull request as ready for review May 20, 2026 22:51
@felickz felickz marked this pull request as draft May 20, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants