Skip to content

Remove unused parameters from private load method #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: chore/change_deprecated_icon_method
Choose a base branch
from
Draft

Remove unused parameters from private load method #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379b1fb
Initial plan
Copilot Feb 16, 2026
7f64c10
Simplify load method by removing unused parameters
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/kotlin/com/github/adrienpessu/sarifviewer/SarifFileType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ object SarifFileType : JsonFileType() {
override fun getName() = "SARIF"
override fun getDescription() = "SARIF file"
override fun getDefaultExtension() = "sarif"
override fun getIcon(): Icon = load("com.github.adrienpessu.sarifviewer/sarif.svg", -2129886975, 0);
override fun getIcon(): Icon = load("com.github.adrienpessu.sarifviewer/sarif.svg")


fun openFileInAssociatedApplication(project: Project?, file: VirtualFile): Boolean {
Expand All @@ -36,7 +36,7 @@ object SarifFileType : JsonFileType() {
return true
}

private fun load(path: String, cacheKey: Int, flags: Int): Icon {
private fun load(path: String): Icon {
return IconLoader.getIcon(path, SarifFileType::class.java.classLoader)
}

Expand Down
Loading