fix(controller): sync Human worker allowlist#972
Conversation
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-07-13 16:13:15 UTC |
eb2b02b to
fceeffd
Compare
|
@shiyiyue1102 Hi! This PR's change is controller-only (Human Reconciler + Worker annotation markers); it doesn't touch the Manager agent runtime or the worker-create code path. Could you either re-run CI or merge if you agree the flake is unrelated? Happy to dig further if you can point me at what assertion actually failed. |
fceeffd to
742b237
Compare
|
Synchronizing Human room access with runtime allow-lists is high value, but this branch is not independently reviewable yet. It conflicts with main and includes the unrelated multi-worker setup change. Please rebase, remove that stacked test commit, use the current AgentTeams annotation and API naming conventions, and add focused coverage for multiple Humans sharing a Worker, access revocation, Human deletion, manual allow-list entries, and idempotent reconciliation. The controller must remove only entries it owns. |
Change-Id: I9796cadada04d018759e242b59390d9b7cad21c2
7e36aa7 to
98ea88d
Compare
Summary
spec.accessibleWorkersinto target WorkerchannelPolicy.groupAllowExtraso room access also grants runtime message permissionFixes #954.
Tests
Local: Go 1.25.0
go test ./internal/controllerpasses, including the three Human allowlist regression tests.Temporary dependency
78e9385), whose full CI passed all 10 integration matrices.7e36aa71passed every build and all 10 integration matrices.