Skip to content

Add support for ARMv8 platform#14

Open
khasim wants to merge 1 commit into
ahawkins:masterfrom
khasim:patch-1
Open

Add support for ARMv8 platform#14
khasim wants to merge 1 commit into
ahawkins:masterfrom
khasim:patch-1

Conversation

@khasim
Copy link
Copy Markdown

@khasim khasim commented Sep 6, 2018

The following changes are done to get Thrift working on docker containers running on ARMv8,

a) The wheezy base package doesn't work for arm64, hence moving to latest debian "stretch" package.
b) Download the golang package based on the architecture as they are different for arm64 and amd64

The following changes are done to get Thrift working on docker containers running on ARMv8,

a) The wheezy base package doesn't work for arm64, hence moving to latest debian "stretch" package.
b) Download the golang package based on the architecture as they are different for arm64 and amd64
@lag-linaro
Copy link
Copy Markdown

This PR LGTM.

Is there any chance we can have it merged please?

@lag-linaro
Copy link
Copy Markdown

Is this project still maintained? If not, perhaps it should be deprecated.

@jeking3
Copy link
Copy Markdown
Contributor

jeking3 commented Feb 6, 2019

This project is not intended to provide a runtime environment for thrift. It provides the thrift compiler which is a code generator written in C++, and makes it easier for folks using other languages to compile thrift files. I would recommend closing this.

@lag-linaro
Copy link
Copy Markdown

Actually @jeking3 this project is intended to provide a runtime environment for people to run Thrift. When you say "this project", I think you are referring to the parent project, https://github.com/apache/thrift, which you help maintain, right?

If this project is still maintained, it should be extended to support other architectures.

@jeking3
Copy link
Copy Markdown
Contributor

jeking3 commented Feb 7, 2019

I do not see how this project provides a runtime environment for people to run thrift projects. It provides the compiler, which is useful when you are using a language like NodeJS and need a way to compile thrift without building it. This container has some preliminary support for golang and that's it. No ruby, python. dotnet, nodejs, swift, as3, ... in here. That's what I base my assumption on, that this project provides a thrift compiler, which is a useful thing to provide. If you want a container that supports all 28 languages thrift supports including the runtime libraries for those languages, you would want to use the container the apache/thrift project uses to build thrift in CI.

Perhaps people use this as a base docker image and then layer a runtime environment on top of it for the language(s) they are using, in their own Dockerfile? Is that how this is used? That would also make sense. But again, in that case, this is just providing the compiler.

@lag-linaro
Copy link
Copy Markdown

To be honest, I have no idea how this project is consumed.

All I can say is that many people (1M+) are consuming it, so it must be of use to someone.

If people are consuming it, we would like provide the possibility for it to be used on an AArch64 platforms.

@lag-linaro
Copy link
Copy Markdown

@ahawkins any chance of updating the now out-of-date wheezy base to stretch?

Comment thread 0.11/Dockerfile
&& cd / \
&& rm -rf /usr/src/thrift \
&& curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz \
&& if [ $(uname -m) = "aarch64" ]; then \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend you manage your own Dockerfile and the go runtime you need on top of the thrift compiler Dockerfile given here. You are likely to have specific go version requirements different from others, and this project would not be able to maintain all the variants.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note in the 0.12 version Dockerfile, the go runtime is not installed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants