Skip to content

Add support for ARMv8 platform #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khasim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for ARMv8 platform #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions 0.11/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM debian:wheezy
FROM debian:stretch
LABEL authors="Adam Hawkins <hi@ahawkins.me>"

ENV THRIFT_VERSION 0.11.0
Expand Down Expand Up @@ -31,7 +31,11 @@ RUN buildDeps=" \
&& make install \
&& cd / \
&& rm -rf /usr/src/thrift \
&& curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz \
&& if [ $(uname -m) = "aarch64" ]; then \
Copy link
Copy Markdown
Contributor

@jeking3 jeking3 Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend you manage your own Dockerfile and the go runtime you need on top of the thrift compiler Dockerfile given here. You are likely to have specific go version requirements different from others, and this project would not be able to maintain all the variants.

Copy link
Copy Markdown
Contributor

@jeking3 jeking3 Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note in the 0.12 version Dockerfile, the go runtime is not installed at all.

curl -k -sSL "https://storage.googleapis.com/golang/go1.10.1.linux-arm64.tar.gz" -o go.tar.gz ; \
else \
curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz ; \
fi \
&& tar xzf go.tar.gz \
&& rm go.tar.gz \
&& cp go/bin/gofmt /usr/bin/gofmt \
Expand Down