Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude overlapping collidable points during collision parsing #382

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Feb 27, 2025

This PR implements a logic to filter out overlapping collidable points when extracting their positions, ensuring unique points are processed for contact parameters. This is particularly useful when dealing with closed-loop kinematic chains or ErgoCub models


📚 Documentation preview 📚: https://jaxsim--382.org.readthedocs.build//382/

@flferretti flferretti self-assigned this Feb 27, 2025
@flferretti flferretti force-pushed the exclude_overlapping_points branch from 3da2595 to 36d8490 Compare February 27, 2025 09:23
@flferretti flferretti marked this pull request as ready for review February 27, 2025 09:23
@flferretti flferretti requested a review from xela-95 as a code owner February 27, 2025 09:23
@flferretti flferretti marked this pull request as draft February 27, 2025 09:36
Copy link
Member

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Do we want it JAXSIM_COLLISION_INCLUDE_OVERLAPS=False by default?
(Just asking because previously it was working as if it was True)

@flferretti
Copy link
Collaborator Author

LGTM! Do we want it JAXSIM_COLLISION_INCLUDE_OVERLAPS=False by default? (Just asking because previously it was working as if it was True)

Thanks @younik! I'm getting some errors in CI which I need to fix, but once fixed, we may consider leaving this on by default as it can improve performances on some models

@flferretti flferretti force-pushed the exclude_overlapping_points branch from 67aa99f to 84da76b Compare March 4, 2025 09:26
@flferretti flferretti marked this pull request as ready for review March 4, 2025 09:26
@flferretti flferretti marked this pull request as draft March 5, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants