feat: add root-cause assessment summary to diagnosis output#40
Open
aminalaee wants to merge 3 commits into
Open
feat: add root-cause assessment summary to diagnosis output#40aminalaee wants to merge 3 commits into
aminalaee wants to merge 3 commits into
Conversation
Reduce fired findings and metrics into a single "Likely bottleneck" summary, shown before the detailed findings in text output and as a top-level `assessment` field in JSON. This turns the report from a list of independent findings into a concise triage of the most likely cause. The assessment is a read-only reducer over DiagnosisResult: it consumes rule results (never re-running thresholds), draws its evidence from the findings that actually fired, and stays conservative — returning "no clear bottleneck" or low confidence when evidence is weak or conflicting. Absent traffic metrics are treated as unknown rather than idle.
Only show the "Likely bottleneck" block when there is a real bottleneck to name — on a clean run it just echoed "no issues detected". Also dedupe assessment evidence lines that cite the same metric (e.g. waiting requests reported by several findings), and refresh docs/demo.png to include the new assessment section.
Add a "Root-cause summary" feature bullet, include the "Likely bottleneck" section in the example output, and reword the intro to mention the summary shown above the detailed findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.