Skip to content

Conversation

@StancaPop
Copy link
Contributor

@StancaPop StancaPop commented Aug 5, 2025

PR Description

Add testbench support for cn0577 & adaq2387x.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • New test (change that adds new test program and/or testbench)
  • Breaking change (has dependencies in other repositories/testbenches)
  • Documentation (change that adds or modifies documentation)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have ran all testbenches affected by this PR
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Errors on compilation/elaboration/simulation
  • I have set the verbosity level to none for the test program

@StancaPop StancaPop requested a review from a team as a code owner August 5, 2025 16:06
@StancaPop StancaPop added the new New testbench label Aug 5, 2025
@StancaPop StancaPop marked this pull request as draft August 5, 2025 16:08
@StancaPop
Copy link
Contributor Author

To be tested with analogdevicesinc/hdl#1870

@StancaPop StancaPop marked this pull request as ready for review August 6, 2025 12:57
@StancaPop StancaPop force-pushed the add_cn0577_tb_s branch 2 times, most recently from 8138e90 to 8979778 Compare August 12, 2025 12:34
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
github-actions bot added a commit that referenced this pull request Sep 9, 2025
@StancaPop
Copy link
Contributor Author

To be used with the HDL main branch.

github-actions bot added a commit that referenced this pull request Sep 17, 2025
@StancaPop
Copy link
Contributor Author

Converting the testbench to draft since the cn0577 HDL reference design will be updated here: analogdevicesinc/hdl#1919

This will cause the testbench to fail because of the following modification:

  • ADC_RES parameter has been removed; the cn0577 design will support only the LTC2387-18 variant

Solution:

  • This testbench can be renamed and repurposed for the adaq2387x family, that was separated from the cn0577 (both being built around axi_ltc2387) and supports both resolutions. The HDL project is still under development.

@StancaPop StancaPop marked this pull request as draft September 17, 2025 13:14
github-actions bot added a commit that referenced this pull request Sep 22, 2025
github-actions bot added a commit that referenced this pull request Sep 22, 2025
@StancaPop StancaPop changed the title cn0577: Add testbench cn0577_adaq2387x: Add testbench Sep 22, 2025
@StancaPop
Copy link
Contributor Author

Since the cn0577 & adaq2387x projects have been separated in HDL, repurposed this testbench to support both projects.
To be tested with: https://github.com/analogdevicesinc/hdl/tree/add_adaq2387x_s

github-actions bot added a commit that referenced this pull request Oct 23, 2025
@StancaPop StancaPop marked this pull request as ready for review October 23, 2025 14:20
Comment on lines +64 to +65
output reg dco_p,
output reg dco_n,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used in the system_tb, it has its own logic to create the dco_p and dco_n signals.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the input and output signals and update the lists in the test_program, as well as in the system_tb.
Note: system_tb was updated, dco_p and dco_n signals are generated inside the test_program.

Copy link
Collaborator

@IstvanZsSzekely IstvanZsSzekely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL WARNING: [BD 41-759] The input pins (listed below) are either not connected or do not have a source port, and they don't have a tie-off specified. These pins are tied-off to all 0's to avoid error in Implementation flow.
Please check your design and connect them as needed:
/axi_ltc2387/delay_clk
Related: WARNING: [BD 41-597] NET <sys_200m_clk> has no source

github-actions bot added a commit that referenced this pull request Oct 27, 2025
github-actions bot added a commit that referenced this pull request Oct 29, 2025
@StancaPop
Copy link
Contributor Author

CRITICAL WARNING: [BD 41-759] The input pins (listed below) are either not connected or do not have a source port, and they don't have a tie-off specified. These pins are tied-off to all 0's to avoid error in Implementation flow. Please check your design and connect them as needed: /axi_ltc2387/delay_clk Related: WARNING: [BD 41-597] NET <sys_200m_clk> has no source

Resolved in 176ab82
Disconnected the delay_clk from sys_200m_clk and connected it to sys_dma_clk.

github-actions bot added a commit that referenced this pull request Oct 29, 2025
Comment on lines +64 to +65
output reg dco_p,
output reg dco_n,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the input and output signals and update the lists in the test_program, as well as in the system_tb.
Note: system_tb was updated, dco_p and dco_n signals are generated inside the test_program.

Comment on lines 171 to 179
initial begin
forever begin
@(posedge dco_in, negedge dco_in) begin
#1
dco_p <= dco_in;
dco_n <= ~dco_in;
end
end
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment on dco_p/dco_n.

Comment on lines 164 to 172
initial begin
forever begin
if (clk_gate == 1'b1) begin
dco_init = ref_clk;
end else begin
dco_init = 1'b0;
end
end
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the forever loop is running endlessly, the simulation never passes time 0. Please add a time consuming statement that prevents the hang.
@(posedge clk_gate, negedge clk_gate); seems to be working if added before the conditional statement, but please verify that the testbench is still working as expected.

github-actions bot added a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new New testbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants