fix: unable to load ivy native plugin #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanwonder thank you very much for identifying the bug and fixing it. If you don't mind, I'll do a small clean up and merge this so that we could get it released asap. |
In typescript 4.1.4, ts allows only package names as plugin names, so `@angular/language-service/bundles/ivy` is disabled by ts. This PR will resolve `@angular/language-service` to path `./bundles/ivy.js` when the user enables the Ivy-native language service. fixed angular#1109
kyliau
force-pushed
the
unable-load-ivy-native-plugin
branch
from
1eeb8be to
b75a71a
Compare
kyliau
approved these changes
Feb 16, 2021
Closed
14 tasks
kyliau
added a commit
to kyliau/vscode-ng-language-service
that referenced
this pull request
Feb 26, 2021
Starting from `@angular/language-service` v12.0.0-next.3, the package will dynamically load View Engine or Ivy LS based on the config passed to the plugin. This reverts angular#1111
kyliau
added a commit
to kyliau/vscode-ng-language-service
that referenced
this pull request
Mar 4, 2021
Starting from `@angular/language-service` v12.0.0-next.3, the package will dynamically load View Engine or Ivy LS based on the config passed to the plugin. This reverts angular#1111
kyliau
added a commit
to kyliau/vscode-ng-language-service
that referenced
this pull request
Mar 4, 2021
Starting from `@angular/language-service` v12.0.0-next.3, the package will dynamically load View Engine or Ivy LS based on the config passed to the plugin. This reverts angular#1111
kyliau
added a commit
that referenced
this pull request
Mar 4, 2021
Starting from `@angular/language-service` v12.0.0-next.3, the package will dynamically load View Engine or Ivy LS based on the config passed to the plugin. This reverts #1111
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript 4.1.4, ts allows only package names as plugin names,
so
@angular/language-service/bundles/ivyis disabled by ts. ThisPR will resolve
@angular/language-serviceto path./bundles/ivy.jswhen the user enables the Ivy-native language service.
fixed #1109