fix: prepare tools FindLogos and FindAndRemoveLogos #2460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsing the newly added field in v1 protos logo_problem_area_id for FindLogos import the right request for FindAndRemoveLogo (FindAndRemoveLogoRequest instead of FindLogoRequest) Parse the tracked_command_response response's subfield as return value
b-matteo
requested review from
RobPasMue,
jacobrkerstetter,
smereu and
umutsoysalansys
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (86.99%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
- Coverage 90.17% 86.99% -3.18%
==========================================
Files 169 167 -2
Lines 12138 12084 -54
==========================================
- Hits 10945 10513 -432
- Misses 1193 1571 +378 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobrkerstetter
changed the title
umutsoysalansys
approved these changes
Dec 11, 2025
Member
|
@b-matteo please resolve the conflicts whenever you get the chance |
Contributor
Author
|
Changes already merged by @smereu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT: the tests will pass only once #2456 gets merged
parsing the newly added field in v1 protos logo_problem_area_id for FindLogos
import the right request for FindAndRemoveLogo (FindAndRemoveLogoRequest instead of FindLogoRequest)
Parse the tracked_command_response response's subfield as return value
Issue linked
None
Checklist
feat: extrude circle to cylinder)