Skip to content

fix: prepare tools FindLogos and FindAndRemoveLogos #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
b-matteo wants to merge 3 commits into from
Closed

fix: prepare tools FindLogos and FindAndRemoveLogos #2460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f244df5
Fix prepare tools FindLogos and FindAndRemoveLogos
b-matteo Dec 11, 2025
3502b4a
chore: adding changelog file 2460.maintenance.md [dependabot-skip]
pyansys-ci-bot Dec 11, 2025
54b4433
chore: adding changelog file 2460.fixed.md [dependabot-skip]
pyansys-ci-bot Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/2460.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix: prepare tools FindLogos and FindAndRemoveLogos
11 changes: 7 additions & 4 deletions src/ansys/geometry/core/_grpc/_services/v1/prepare_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,13 +190,16 @@ def find_logos(self, **kwargs) -> dict: # noqa: D102

# Return the response - formatted as a dictionary
return {
"id": response.id,
"id": response.logo_problem_area_id.id,
"face_ids": [face.id for face in response.logo_faces],
}

@protect_grpc
def find_and_remove_logos(self, **kwargs) -> dict: # noqa: D102
from ansys.api.discovery.v1.operations.prepare_pb2 import FindLogoOptions, FindLogosRequest
from ansys.api.discovery.v1.operations.prepare_pb2 import (
FindAndRemoveLogosRequest,
FindLogoOptions,
)

# Check height objects
min_height = (
Expand All @@ -211,7 +214,7 @@ def find_and_remove_logos(self, **kwargs) -> dict: # noqa: D102
)

# Create the request - assumes all inputs are valid and of the proper type
request = FindLogosRequest(
request = FindAndRemoveLogosRequest(
body_ids=[build_grpc_id(body) for body in kwargs["bodies"]],
options=FindLogoOptions(
min_height=min_height,
Expand All @@ -223,7 +226,7 @@ def find_and_remove_logos(self, **kwargs) -> dict: # noqa: D102
response = self.stub.FindAndRemoveLogos(request)

# Return the response - formatted as a dictionary
return get_standard_tracker_response(response)
return get_standard_tracker_response(response.tracked_command_response)

@protect_grpc
def remove_logo(self, **kwargs): # noqa: D102
Expand Down
Loading