Benchmarks for Arrow IPC writer #7090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 6, 2025
| use criterion::{criterion_group, criterion_main, Criterion}; | ||
| use std::sync::Arc; | ||
|
|
||
| fn criterion_benchmark(c: &mut Criterion) { |
There was a problem hiding this comment.
This benchmark benchmarks writing 10 batches (rather than the original benchmark from @andygrove that did both 1 and 10 batches). I profiled them both and the actual encoding of batches far dwarfs the writer creation time so I thought it would be best to focus on just writing
alamb
changed the title
This was referenced Feb 6, 2025
tustvold
approved these changes
Feb 8, 2025
tustvold
approved these changes
Feb 8, 2025
|
Thank you @tustvold |
phillipleblanc
pushed a commit
to spiceai/arrow-rs
that referenced
this pull request
Feb 10, 2025
* Add benchmarks for Arrow IPC writer * Add benchmarks for Arrow IPC writer * reuse target buffer * rename, etc * Add compression type * update --------- Co-authored-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We want to make the IPC writer faster by turning off validation but we currently don't have any benchmarks for this feature
What changes are included in this PR?
Add IPC writing benchmarks, based on @andygrove's work in #6972
I am working in IPC reading benchmarks as well
Are there any user-facing changes?
No, this is just benchmark code