GH-37722: [Java][FlightRPC] Deprecate stateful login methods#37833
Merged
lidavidm merged 1 commit intoapache:mainfrom Sep 25, 2023
Merged
GH-37722: [Java][FlightRPC] Deprecate stateful login methods#37833lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: Java
awaiting committer review
Member
|
@lidavidm Should I follow suit with the same on the Go side? |
zeroshade
approved these changes
Sep 22, 2023
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Makes sense to me, I think the same interfaces still exist on the Go and C++ implementations, so we probably want to update the documentation for both of them too
github-actions
bot
added
awaiting merge
Member
Author
|
Yes, anything based on Handshake should not be preferred by new application code (it's probably just a footgun at best) |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 64acef8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…pache#37833) ### Rationale for this change The existence of these interfaces confuses users and leads them to antipatterns. ### What changes are included in this PR? Deprecate (but not for removal) the old interfaces. ### Are these changes tested? N/A ### Are there any user-facing changes? Yes. * Closes: apache#37722 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The existence of these interfaces confuses users and leads them to antipatterns.
What changes are included in this PR?
Deprecate (but not for removal) the old interfaces.
Are these changes tested?
N/A
Are there any user-facing changes?
Yes.
adbc_driver_flightsql.connectto Java Flight Server #37722