Skip to content

GH-37722: [Java][FlightRPC] Deprecate stateful login methods #37833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Sep 25, 2023
Merged

GH-37722: [Java][FlightRPC] Deprecate stateful login methods #37833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions java/flight/flight-core/src/main/java/org/apache/arrow/flight/auth/ClientAuthHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@

import java.util.Iterator;

import org.apache.arrow.flight.FlightClient;

/**
* Implement authentication for Flight on the client side.
*
* @deprecated As of 14.0.0. This implements a stateful "login" flow that does not play well with
* distributed or stateless systems. It will not be removed, but should not be used. Instead
* see {@link FlightClient#authenticateBasicToken(String, String)}.
*/
@Deprecated
public interface ClientAuthHandler {
/**
* Handle the initial handshake with the server.
Expand Down
9 changes: 9 additions & 0 deletions java/flight/flight-core/src/main/java/org/apache/arrow/flight/auth/ServerAuthHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,18 @@
import java.util.Iterator;
import java.util.Optional;

import org.apache.arrow.flight.FlightServer;
import org.apache.arrow.flight.auth2.CallHeaderAuthenticator;

/**
* Interface for Server side authentication handlers.
*
* @deprecated As of 14.0.0. This implements a stateful "login" flow that does not play well with
* distributed or stateless systems. It will not be removed, but should not be used. Instead,
* see {@link FlightServer.Builder#headerAuthenticator(CallHeaderAuthenticator)}
* and {@link CallHeaderAuthenticator}.
*/
@Deprecated
public interface ServerAuthHandler {

/**
Expand Down