Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick](branch2.1) Impl translate and url encode 2.1 #41051

Merged
merged 5 commits into from
Sep 23, 2024
Merged

[cherry-pick](branch2.1) Impl translate and url encode 2.1 #41051

merged 5 commits into from
Sep 23, 2024

Conversation

suxiaogang223
Copy link
Contributor

Proposed changes

pick #40567

some code about const folding should wait the pr picked: #40441

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions[bot]
github-actions bot reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/util/url_coding.cpp Outdated Show resolved Hide resolved
be/src/vec/functions/function_string.h Show resolved Hide resolved
@suxiaogang223
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/util/url_coding.cpp Show resolved Hide resolved
@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9334/25815)
Line Coverage: 27.70% (76641/276693)
Region Coverage: 26.48% (39373/148664)
Branch Coverage: 23.28% (20050/86118)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a315789e8d447be5b7bb725655c7a01671d377b5_a315789e8d447be5b7bb725655c7a01671d377b5/report/index.html

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9334/25815)
Line Coverage: 27.71% (76673/276707)
Region Coverage: 26.48% (39381/148703)
Branch Coverage: 23.27% (20050/86144)
Coverage Report: http://coverage.selectdb-in.cc/coverage/68c4b1bb9279fa780b36b10571c1cd7c44fa02b2_68c4b1bb9279fa780b36b10571c1cd7c44fa02b2/report/index.html

@suxiaogang223 suxiaogang223 force-pushed the impl_translate_and_url_encode_2.1 branch from 3d7efd6 to a08677d Compare September 22, 2024 15:35
@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.14% (9335/25828)
Line Coverage: 27.68% (76639/276826)
Region Coverage: 26.47% (39376/148760)
Branch Coverage: 23.27% (20049/86174)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a08677d4c470d0e450508ee3fcb0aec911f42914_a08677d4c470d0e450508ee3fcb0aec911f42914/report/index.html

@morningman morningman merged commit f6917ac into apache:branch-2.1 Sep 23, 2024
19 of 21 checks passed
@suxiaogang223 suxiaogang223 deleted the impl_translate_and_url_encode_2.1 branch September 26, 2024 17:11
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suxiaogang223 @doris-robot @morningman