[FLINK-40291][metrics] Fix instrumentation scope hardcoded - #28876
Open
charlesdong1991 wants to merge 2 commits into
Open
[FLINK-40291][metrics] Fix instrumentation scope hardcoded#28876charlesdong1991 wants to merge 2 commits into
charlesdong1991 wants to merge 2 commits into
Conversation
charlesdong1991
changed the title
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This scope name is emitted as the
scope.namefield on every OTel ScopeMetrics envelope produced by the reporter. It does not reference Flink at all, which is confusing for operators inspecting exported data and for anyone configuring OTel Collector processors/filters that match on instrumentation scope name.Brief change log
Verifying this change
This change added tests and can be verified as follows: