Skip to content

[FLINK-40291][metrics] Fix instrumentation scope hardcoded #28876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charlesdong1991 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

[FLINK-40291][metrics] Fix instrumentation scope hardcoded #28876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27e142e
Fix wrong hardcoded instrumentation scope
charlesdong1991 Aug 2, 2026
a252f3e
fix lint
charlesdong1991 Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-metrics-otel/src/main/java/org/apache/flink/metrics/otel/OpenTelemetryMetricAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ class OpenTelemetryMetricAdapter {
static final double[] HISTOGRAM_QUANTILES = {0.5, 0.75, 0.95, 0.99};

static final InstrumentationScopeInfo INSTRUMENTATION_SCOPE_INFO =
InstrumentationScopeInfo.create("io.confluent.flink.common.metrics");
InstrumentationScopeInfo.create(
OpenTelemetryMetricAdapter.class.getPackage().getName());

public static Optional<MetricData> convertCounter(
CollectionMetadata collectionMetadata,
Expand Down
2 changes: 1 addition & 1 deletion ...s-otel/src/test/java/org/apache/flink/metrics/otel/OpenTelemetryMetricReporterITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void testReport() throws Exception {
JsonNode scopeMetrics =
json.findPath("resourceMetrics").findPath("scopeMetrics");
assertThat(scopeMetrics.findPath("scope").findPath("name").asText())
.isEqualTo("io.confluent.flink.common.metrics");
.isEqualTo("org.apache.flink.metrics.otel");
JsonNode metrics = scopeMetrics.findPath("metrics");

List<String> metricNames = extractMetricNames(json);
Expand Down