Add catalog test suite to unify catalog's behavior.#2131
Merged
blackmwk merged 9 commits intoapache:mainfrom Mar 12, 2026
Merged
Add catalog test suite to unify catalog's behavior.#2131blackmwk merged 9 commits intoapache:mainfrom
blackmwk merged 9 commits intoapache:mainfrom
Conversation
blackmwk
requested review from
CTTY,
kevinjqliu and
sdd
and removed request for
kevinjqliu
Contributor
Author
|
cc @kevinjqliu @sdd @Xuanwo @Fokko PTAL |
Xuanwo
reviewed
Mar 3, 2026
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this, really great!
Contributor
Author
|
cc @Xuanwo PTAL, I have addressed comments. |
Xuanwo
approved these changes
Mar 12, 2026
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
In this pr we introduced catalog test suite in catalog-loader, which could unify the behavior of catalogs.
Are these changes tested?
Yes.