Merged
Conversation
hareshkh
approved these changes
Mar 2, 2026
mbutrovich
approved these changes
Mar 2, 2026
Collaborator
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks @xanderbailey!
Contributor
|
Thanks @xanderbailey for this pr, please do a rebase to resolve conflicts. |
xanderbailey
force-pushed
the
xb/datafusion_52.2
branch
from
02e37ec to
ec09cf0
Compare
Contributor
Author
|
Rebased and I'm getting: Seems like we need to bump MSRV to 1.91 |
blackmwk
pushed a commit
that referenced
this pull request
Mar 5, 2026
## Which issue does this PR close? #2199 requires a bump to MSRV 1.91.0. This version is within the policy of this project. <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
Contributor
|
hi @xanderbailey #2204 merged, please update this pr |
Contributor
|
I see #2206 should we consider bump directly to 53? |
xanderbailey
force-pushed
the
xb/datafusion_52.2
branch
from
ec09cf0 to
45e49b9
Compare
Contributor
Author
I think 53 isn't released yet so I'm fine with merging this first apache/datafusion#19692 |
Collaborator
Agreed. At the moment, #2206 is mostly just to test for the DF53 release process. |
14 tasks
blackmwk
approved these changes
Mar 6, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @xanderbailey for this fix, and @mbutrovich for review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue.
What changes are included in this PR?
Bumping from DataFusion 52.1 -> 52.2
Changelog for changes are here. https://github.com/apache/datafusion/blob/branch-52/dev/changelog/52.2.0.md just bug fixes.
Are these changes tested?