KAFKA-16331: Remove KafkaClientSupplier from unit tests #17330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
changed the title
mjsax
changed the title
bbejeck
reviewed
Oct 1, 2024
| @@ -1950,16 +1938,6 @@ public static class ProductionExceptionHandlerMock implements ProductionExceptio | |||
| private TaskId expectedTaskId; | |||
| private SerializationExceptionOrigin expectedSerializationExceptionOrigin; | |||
|
|
|||
| // No args constructor, referred in StreamsConfigTest | |||
| public ProductionExceptionHandlerMock() { | |||
There was a problem hiding this comment.
Why remove this? More for my own understanding
There was a problem hiding this comment.
Ups. That's actually a slip... need to keep this. Good catch.
We don't pass in a client-supplier into `StreamsProducer` any longer, so we can simplify `StreamsProducerTest` and remove client-supplier.
mjsax
force-pushed
the
kafka-16331-eosv1-cleanup-test
branch
from
0c87c42 to
5129fc7
Compare
bbejeck
approved these changes
Oct 7, 2024
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
We don't pass in a client-supplier into `StreamsProducer` any longer, so we can simplify `StreamsProducerTest` and remove client-supplier. Reviewers: Bill Bejeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't pass in a client-supplier into
StreamsProducerany longer, so we can simplify multiple tests by removing client-supplier.Should have done this in #17259 but missed it...