HDDS-15146. Remove getDatanodeInfo(DatanodeDetails) from NodeManager.#10169
HDDS-15146. Remove getDatanodeInfo(DatanodeDetails) from NodeManager.#10169szetszwo wants to merge 6 commits into
Conversation
adoroszlai
changed the title
| public DatanodeInfo getDatanodeInfo(DatanodeDetails dd) { | ||
| if (dd instanceof DatanodeInfo) { | ||
| return (DatanodeInfo) dd; | ||
| } |
There was a problem hiding this comment.
This is method is public but only used by MockNodeManager.
| for (DatanodeDetails node : scm.getScmNodeManager().getNodes(opState, state)) { | ||
| NodeStatus ns = scm.getScmNodeManager().getNodeStatus(node); | ||
| DatanodeInfo datanodeInfo = scm.getScmNodeManager().getDatanodeInfo(node); | ||
| DatanodeInfo datanodeInfo = node instanceof DatanodeInfo ? (DatanodeInfo) node : null; |
There was a problem hiding this comment.
why do we need instanceof check here, we already know that getNodes returns DatanodeInfo?
| List<Node> filteredScmNodes = scmNodes.stream() | ||
| .filter(n -> deadNodesOnRecon.contains( | ||
| DatanodeDetails.getFromProtoBuf(n.getNodeID()))) | ||
| .filter(n -> deadNodesOnRecon.contains(n.getNodeID().getUuid())) |
There was a problem hiding this comment.
n.getNodeID().getUuid() reads the deprecated string uuid field
instead we could use something like
.filter(n -> deadNodesOnRecon.contains(DatanodeID.fromProto(n.getNodeID().getId()).getID()))
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it. |
2 participants
What changes were proposed in this pull request?
In SCMNodeManager, the underlying DatanodeDetails object actually is already a DatanodeInfo.
What is the link to the Apache JIRA
HDDS-15146
How was this patch tested?
Updating existing tests.