RANGER-5345: [GDS] Shared resource creation api is failing for oracle db #694
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshkumar-yadav
requested review from
rameeshm,
mneethiraj,
pradeepagrawal8184 and
kishorgollapalliwar
rameeshm
reviewed
Oct 1, 2025
| return getMapper().readValue(jsonStr, TYPE_LIST_RANGER_GDS_MASK_INFO); | ||
| } catch (Exception e) { | ||
| LOG.error("Cannot get Map<String, RangerPolicyItemDataMaskInfo> from {}", jsonStr, e); | ||
| LOG.error("Cannot get List<RangerGdsMaskInfo> from {}", jsonStr, e); |
There was a problem hiding this comment.
Should there be null check on this "if (StringUtils.isNotEmpty(jsonStr)) " and then do readValue to avoid excetion?
There was a problem hiding this comment.
Update the Patch. kindly review
Sanket-Shelar
force-pushed
the
RANGER-5345
branch
from
e5ad9fe to
32f836b
Compare
rameeshm
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shared Resource API /dataset/{id}/resources/{serviceName} is failing for Oracle database as it is using distinct with CLOB type in query.
Additionally whenever GDS resource APIs are invoked, there are logs in error as SubResourceMasks and DefaultTagMasks are null.
How was this patch tested?
Build Successful. API tested in oracle and checked logs and error logs were not present.