[SPARK-52249][PS] Enable divide-by-zero for truediv with ANSI enabled #50972
+39
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
|
Should be merged after #51035 |
xinrong-meng
force-pushed
the
divide_0
branch
2 times, most recently
from
2c60487 to
443e641
Compare
| F.lit(right != 0) | F.lit(right).isNull(), | ||
| left.__div__(right), | ||
| ).otherwise(F.lit(np.inf).__div__(left)) | ||
| if not get_option("compute.ansi_mode_support"): |
There was a problem hiding this comment.
can we optimize out this get_option which needs a separate Config RPC?
I guess we can just use the new branch
There was a problem hiding this comment.
Sorry would you mind clarifying what you meant?
ueshin
reviewed
May 28, 2025
ueshin
reviewed
May 28, 2025
| @@ -111,7 +111,6 @@ def test_binary_operator_sub(self): | |||
| psdf = ps.DataFrame({"a": ["x"], "b": ["y"]}) | |||
| self.assertRaisesRegex(TypeError, ks_err_msg, lambda: psdf["a"] - psdf["b"]) | |||
|
|
|||
| @unittest.skipIf(is_ansi_mode_test, ansi_mode_not_supported_message) | |||
There was a problem hiding this comment.
Could you also try to find where we can remove skipping caused by the division error?
There was a problem hiding this comment.
Can I follow up with https://issues.apache.org/jira/browse/SPARK-52349 on that if you don't mind, in order to unblock the other pr?
xinrong-meng
changed the title
ueshin
reviewed
May 28, 2025
python/pyspark/pandas/utils.py
Outdated
| @@ -1070,6 +1070,14 @@ def xor(df1: PySparkDataFrame, df2: PySparkDataFrame) -> PySparkDataFrame: | |||
| ) | |||
|
|
|||
|
|
|||
| def is_ansi_mode_enabled() -> bool: | |||
There was a problem hiding this comment.
Shall we explicitly pass spark? SparkSession.getActiveSession() is not light.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable divide-by-zero for truediv with ANSI enabled
Why are the changes needed?
Part of https://issues.apache.org/jira/browse/SPARK-52169
Does this PR introduce any user-facing change?
Yes, divide-by-zero for truediv is enabled with ANSI enabled
FROM
TO
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No