[SPARK-52536] Set AsyncProfilerLoader extractionDir to spark local dir #51229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthchandra
approved these changes
Jun 23, 2025
HyukjinKwon
approved these changes
Jun 24, 2025
|
Merged to master. |
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jun 25, 2025
### What changes were proposed in this pull request? Set AsyncProfilerLoader extractionDir to spark local dir ### Why are the changes needed? `AsyncProfilerLoader` uses `user.home` dir to store the extracted libraries by default . When `user.home` dir is not initialized, it will cause `AsyncProfilerLoader.load` to fail. https://github.com/jvm-profiling-tools/ap-loader/blob/main/src/main/java/one/profiler/AsyncProfilerLoader.java#L139-L152 We can specify `AsyncProfilerLoader.extractionDir` to spark local dir to avoid this issue. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Tested manually in our internal yarn cluster  ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51229 from wForget/SPARK-52536. Authored-by: wforget <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
turboFei
pushed a commit
to apache/celeborn
that referenced
this pull request
Jun 25, 2025
…eborn.worker.jvmProfiler.localDir ### What changes were proposed in this pull request? Specify `extractionDir` of `AsyncProfilerLoader` with `celeborn.worker.jvmProfiler.localDir`. ### Why are the changes needed? `AsyncProfilerLoader` uses `user.home` directory to store the extracted libraries by default . When `user.home` directory is not initialized, it will cause `AsyncProfilerLoader#load` to fail. `extractionDir` of `AsyncProfilerLoader` could be specified with `celeborn.worker.jvmProfiler.localDir` to avoid failure of loading. Backport apache/spark#51229. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. Closes #3345 from SteNicholas/CELEBORN-2046. Lead-authored-by: SteNicholas <[email protected]> Co-authored-by: 子懿 <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
turboFei
pushed a commit
to apache/celeborn
that referenced
this pull request
Jun 25, 2025
…eborn.worker.jvmProfiler.localDir ### What changes were proposed in this pull request? Specify `extractionDir` of `AsyncProfilerLoader` with `celeborn.worker.jvmProfiler.localDir`. ### Why are the changes needed? `AsyncProfilerLoader` uses `user.home` directory to store the extracted libraries by default . When `user.home` directory is not initialized, it will cause `AsyncProfilerLoader#load` to fail. `extractionDir` of `AsyncProfilerLoader` could be specified with `celeborn.worker.jvmProfiler.localDir` to avoid failure of loading. Backport apache/spark#51229. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. Closes #3345 from SteNicholas/CELEBORN-2046. Lead-authored-by: SteNicholas <[email protected]> Co-authored-by: 子懿 <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit 3ee3a26) Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set AsyncProfilerLoader extractionDir to spark local dir
Why are the changes needed?
AsyncProfilerLoaderusesuser.homedir to store the extracted libraries by default . Whenuser.homedir is not initialized, it will causeAsyncProfilerLoader.loadto fail.https://github.com/jvm-profiling-tools/ap-loader/blob/main/src/main/java/one/profiler/AsyncProfilerLoader.java#L139-L152
We can specify
AsyncProfilerLoader.extractionDirto spark local dir to avoid this issue.Does this PR introduce any user-facing change?
How was this patch tested?
Tested manually in our internal yarn cluster
Was this patch authored or co-authored using generative AI tooling?
No