Skip to content

[SPARK-52551][SQL][FOLLOW-UP] Enable ANSI mode in PushablePredicateSuite #51329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-52551][SQL][FOLLOW-UP] Enable ANSI mode in PushablePredicateSuite #51329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/connector/PushablePredicateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.spark.sql.connector

import org.apache.spark.SparkConf
import org.apache.spark.sql.QueryTest
import org.apache.spark.sql.catalyst.expressions.{Cast, Literal}
import org.apache.spark.sql.connector.expressions.filter.{AlwaysTrue, Predicate => V2Predicate}
Expand All @@ -27,6 +28,8 @@ import org.apache.spark.sql.types.BooleanType

class PushablePredicateSuite extends QueryTest with SharedSparkSession {

override def sparkConf: SparkConf = super.sparkConf.set(SQLConf.ANSI_ENABLED, true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, shouldn't we better explicitly enable it for affected test cases only? Either works fine to me. I opened one in #51330 so you can merge either this or that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it for convenience, as DS v2 expressions follow ANSI and we can only translate catalyst expressions (if they are ANSI relevent) into DS v2 expressions if ANSI is enabled. All DS v2 tests should enable ANSI mode.


test("simple boolean expression should always return v2 Predicate") {
Seq(true, false).foreach { createV2Predicate =>
Seq(true, false).foreach { noAssert =>
Expand Down