[SPARK-52551][SQL][FOLLOW-UP] Enable ANSI mode in PushablePredicateSuite #51329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jul 1, 2025
|
|
||
| class PushablePredicateSuite extends QueryTest with SharedSparkSession { | ||
|
|
||
| override def sparkConf: SparkConf = super.sparkConf.set(SQLConf.ANSI_ENABLED, true) |
There was a problem hiding this comment.
Hm, shouldn't we better explicitly enable it for affected test cases only? Either works fine to me. I opened one in #51330 so you can merge either this or that
There was a problem hiding this comment.
I did it for convenience, as DS v2 expressions follow ANSI and we can only translate catalyst expressions (if they are ANSI relevent) into DS v2 expressions if ANSI is enabled. All DS v2 tests should enable ANSI mode.
HyukjinKwon
approved these changes
Jul 1, 2025
dongjoon-hyun
approved these changes
Jul 1, 2025
HyukjinKwon
changed the title
|
Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 14, 2025
### What changes were proposed in this pull request? This is a followup of apache#51247 to fix tests in the non ANSI build ### Why are the changes needed? fix test ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#51330 Closes apache#51329 from cloud-fan/follow. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jul 22, 2025
### What changes were proposed in this pull request? This is a followup of apache#51247 to fix tests in the non ANSI build ### Why are the changes needed? fix test ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#51330 Closes apache#51329 from cloud-fan/follow. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #51247 to fix tests in the non ANSI build
Why are the changes needed?
fix test
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
no
Closes #51330