Skip to content

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jul 1, 2025

What changes were proposed in this pull request?

This PR is a followup of #51247 that explicily enables ANSI for overflow error test case

Why are the changes needed?

The non-ANSI build is broken https://github.com/apache/spark/actions/runs/15987607479/job/45094925023

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

Manually.

Was this patch authored or co-authored using generative AI tooling?

No

Closes #51329

@HyukjinKwon HyukjinKwon closed this Jul 1, 2025
Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM.

HyukjinKwon pushed a commit that referenced this pull request Jul 1, 2025
### What changes were proposed in this pull request?

This is a followup of #51247 to fix tests in the non ANSI build

### Why are the changes needed?

fix test

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

N/A

### Was this patch authored or co-authored using generative AI tooling?

no

Closes #51330

Closes #51329 from cloud-fan/follow.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
asl3 pushed a commit to asl3/spark that referenced this pull request Jul 14, 2025
### What changes were proposed in this pull request?

This is a followup of apache#51247 to fix tests in the non ANSI build

### Why are the changes needed?

fix test

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

N/A

### Was this patch authored or co-authored using generative AI tooling?

no

Closes apache#51330

Closes apache#51329 from cloud-fan/follow.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
haoyangeng-db pushed a commit to haoyangeng-db/apache-spark that referenced this pull request Jul 22, 2025
### What changes were proposed in this pull request?

This is a followup of apache#51247 to fix tests in the non ANSI build

### Why are the changes needed?

fix test

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

N/A

### Was this patch authored or co-authored using generative AI tooling?

no

Closes apache#51330

Closes apache#51329 from cloud-fan/follow.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants