[SYSTEMDS-3421] Adds missing read/writeExternal to ColumnEncoderUDF. #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read/writeExternal functions for ColumnEncoderUDF where missing. This also adds the necessary switch case in the EncoderFactory and a test that currently does nothing.
|
There are two versions of T2 (KDD dataset) -- one with UDF-based scaling and another with scaling outside of transformencode. The UDF task implementation is still in the experimental phase. Internally it uses our eval mechanism. I am not very sure how would that fit in the federated setup. |
|
That is a good point @phaniarnab - the UDF column encoder would not be valid for federated row-partitions we currently work with for the other benchmark use cases. However, for column-partitioned federated data it should work. |
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Oct 31, 2022
The read/writeExternal functions for ColumnEncoderUDF where missing. This also adds the necessary switch case in the EncoderFactory and a test that currently does nothing. Closes apache#1681
|
Fixed the syntax error and opened in new PR. |
Baunsgaard
pushed a commit
to Baunsgaard/systemds
that referenced
this pull request
Nov 11, 2022
The read/writeExternal functions for ColumnEncoderUDF where missing. This also adds the necessary switch case in the EncoderFactory and a test that currently does nothing. Closes apache#1681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read/writeExternal functions for ColumnEncoderUDF where missing.
This also adds the necessary switch case in the EncoderFactory
and a test that currently does nothing.
I encountered this bug when running the FTBench T2 in federated mode with two actual workers. The main issue is that the ColumnEncoderUDF objects on the workers end up with
nullas_fNamebecause the function name is not sent.@mboehm7