[SYSTEMDS-3421] Adds missing read/writeExternal to ColumnEncoderUDF. #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read/writeExternal functions for ColumnEncoderUDF where missing. This also adds the necessary switch case in the EncoderFactory and a test that currently does nothing. Closes apache#1681
Baunsgaard
force-pushed
the
SYSTEMDS-3421
branch
from
64249af to
cb75e3f
Compare
|
Hi @Baunsgaard , This feature is good to go? |
|
This needs some work. So will not be part of the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read/writeExternal functions for ColumnEncoderUDF where missing. This also adds the necessary switch case in the EncoderFactory and a test that currently does nothing.
Closes #1681