fix: Multipart close delimiter parsing #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 420143e82174794efcba033b |
calvincestari
changed the title
calvincestari
changed the title
calvincestari
commented
Nov 26, 2025
| } | ||
|
|
||
| if buffer == Constants.CloseDelimeter { | ||
| if buffer.starts(with: Constants.CloseDelimiter) { |
Member
Author
There was a problem hiding this comment.
This is the crux of the fix.
AnthonyMDev
approved these changes
Dec 2, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Dec 2, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Dec 2, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Dec 2, 2025
62377ef26 fix: Multipart close delimiter parsing (#852) git-subtree-dir: apollo-ios git-subtree-split: 62377ef26f2fb828f66bb994379d3c2c9c24cae8
BobaFetters
pushed a commit
that referenced
this pull request
Dec 2, 2025
git-subtree-dir: apollo-ios git-subtree-mainline: b02afe7 git-subtree-split: 62377ef26f2fb828f66bb994379d3c2c9c24cae8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3612
The multipart chunking logic would throw a parsing error if there was any data after the close delimiter; a close delimiter signals that the multipart stream is finished and we can safely ignore anything beyond it.