Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public non-const coeffs #137

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Add public non-const coeffs #137

merged 1 commit into from
Jun 16, 2020

Conversation

artivis
Copy link
Owner

@artivis artivis commented Jun 12, 2020

Add a public non-const coeffs to LieGroup objects.

Also remove the protected coeffs_nonconst.

Fix #132.

@artivis artivis added the API API change label Jun 12, 2020
@artivis artivis requested a review from joansola June 12, 2020 23:58
@artivis artivis self-assigned this Jun 12, 2020
joansola
joansola approved these changes Jun 13, 2020
View reviewed changes
Copy link
Collaborator

@joansola joansola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!!

@artivis
Copy link
Owner Author

artivis commented Jun 16, 2020

The tests fail because of the newly introduced arm64 job which uses gcc-9 resulting in a bunch of error about deprecated implicit operators.
I'll merge this since the other tests are passing and open a ticket to support gcc-8/9.

@artivis artivis merged commit 8974511 into devel Jun 16, 2020
@artivis artivis deleted the feature/public_non_const_coeffs branch June 16, 2020 23:40
@artivis artivis mentioned this pull request Jun 16, 2020
Closed
4 tasks
@markusgft markusgft mentioned this pull request Jun 17, 2020
Open
@artivis artivis mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joansola joansola joansola approved these changes

Assignees

@artivis artivis

Labels
API API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-const getter for coeffs()
2 participants
@artivis @joansola