Add MANIF_ASSERT #138
Merged
Add MANIF_ASSERT #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #138 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 37 37
Lines 1130 1130
=======================================
Hits 1110 1110
Misses 20 20 |
|
The tests fail because of the newly introduced arm64 job which uses gcc-9 resulting in a bunch of error about deprecated implicit operators. |
|
@joansola Can you please review/approve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macro
MANIF_ASSERT.The macro asserts that a condition is true or throws otherwise. It replaces
MANIF_CHECKfor a couple numerical checks as requested in this comment.MANIF_ASSERTmacro can be disabled by either definingMANIF_NO_DEBUGor the usualNDEBUG.