default memmap parameter to False
#1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
force-pushed
the
default/memmap_false
branch
4 times, most recently
from
29aafc6
to
9bb044f
Compare
|
Unit test failures are real. It looks like there are more tests that need updated for the new default. |
|
#1852 was merged and introduced the "what's new" page for asdf 4.0. Would you update this PR and add an entry describing the default change: |
zacharyburnett
force-pushed
the
default/memmap_false
branch
from
1fe2d64
to
787cd55
Compare
zacharyburnett
commented
Nov 8, 2024
braingram
reviewed
Nov 8, 2024
braingram
reviewed
Nov 8, 2024
braingram
reviewed
Nov 8, 2024
| @@ -976,7 +976,7 @@ def test_memmap_write(tmp_path): | |||
| tmpfile = str(tmp_path / "data.asdf") | |||
| tree = {"data": np.zeros(100)} | |||
|
|
|||
| with asdf.AsdfFile(tree) as af: | |||
| with asdf.AsdfFile(tree, memmap=False) as af: | |||
There was a problem hiding this comment.
Is this needed?
Suggested change
| with asdf.AsdfFile(tree, memmap=False) as af: | |
| with asdf.AsdfFile(tree) as af: |
braingram
reviewed
Nov 8, 2024
Co-authored-by: Brett Graham <[email protected]>
Co-authored-by: Brett Graham <[email protected]>
Co-authored-by: Brett Graham <[email protected]>
|
I think this PR should be good to go once the lines mentioned in #1801 (comment) are removed. |
braingram
reviewed
Nov 8, 2024
Co-authored-by: Brett Graham <[email protected]>
braingram
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on (and blocked by) #1800
Description
default
memmap=FalseChecklist: