chore(copybara): sync commits from Aspect-internal silo #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the `outputs` verb to pick up the query expression from the `query_file` flag. As we need to call `bazel outputs` with a large list of targets to avoid issues with the `manual` tag, rosetta is now passing the targets to the CLI explicitly, in the form `set(//foo //bar //etc)`. This can therefore result in huge command line args, depending on the depth of the target in the repo, and the number of deliverable targets. Closes #4900 --- ### Type of change - New feature or functionality (change which adds functionality) **For changes visible to end-users** - Suggested release notes are provided below: Support use of `--query_file` in `aspect outputs` command. ### Test plan - Manual testing; please provide instructions so we can reproduce: ``` $ echo "set(//cli/core/cmd/aspect)" > aquery.txt $ bazel run //cli -- outputs ExecutableHash --query_file aquery.txt ... INFO: Running command line: bazel-bin/cli/core/cmd/aspect/aspect_/aspect outputs ExecutableHash --query_file aquery.txt //cli/core/cmd/aspect:aspect m3:vEu8cSq8Wltzy4D/RABo+A== ``` GitOrigin-RevId: 6ce527b9f4427b7c55fdeea134c456441cb0b6c2
|
I don't think this commit will fix #602 , this is explicitly enabling the use of |
|
I see, removed the "fixes" tag in that case. |
mattem
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/407c86388bd42af767b828c758c56ed159b33870..6ce527b9f4427b7c55fdeea134c456441cb0b6c2