Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(copybara): sync commits from Aspect-internal silo #659

Merged
merged 1 commit into from
Mar 27, 2024

Commits on Mar 27, 2024

  1. feat: support passing --query_file to outputs verb (#4909)

    Allows the `outputs` verb to pick up the query expression from the
    `query_file` flag.
    
    As we need to call `bazel outputs` with a large list of targets to avoid
    issues with the `manual` tag, rosetta is now passing the targets to the
    CLI explicitly, in the form `set(//foo //bar //etc)`. This can therefore
    result in huge command line args, depending on the depth of the target
    in the repo, and the number of deliverable targets.
    
    Closes #4900
    
    ---
    
    ### Type of change
    
    - New feature or functionality (change which adds functionality)
    
    **For changes visible to end-users**
    
    - Suggested release notes are provided below:
    
    Support use of `--query_file` in `aspect outputs` command.
    
    ### Test plan
    
    - Manual testing; please provide instructions so we can reproduce:
    
    ```
    $ echo "set(//cli/core/cmd/aspect)" > aquery.txt
    
    $ bazel run //cli -- outputs ExecutableHash --query_file aquery.txt
    ...
    INFO: Running command line: bazel-bin/cli/core/cmd/aspect/aspect_/aspect outputs ExecutableHash --query_file aquery.txt
    //cli/core/cmd/aspect:aspect m3:vEu8cSq8Wltzy4D/RABo+A==
    ```
    GitOrigin-RevId: 6ce527b9f4427b7c55fdeea134c456441cb0b6c2
    mattem authored and alexeagle committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    81263d2 View commit details
    Browse the repository at this point in the history