Skip to content

[ty] Render full diagnostics in color#26384

Open
AlexWaygood wants to merge 1 commit into
mainfrom
alex/colored-diagnostics
Open

[ty] Render full diagnostics in color#26384
AlexWaygood wants to merge 1 commit into
mainfrom
alex/colored-diagnostics

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jun 25, 2026

Copy link
Copy Markdown
Member

Context

This builds on the original Click for full diagnostic feature implemented in astral-sh/ruff#26269 and astral-sh/ty-vscode#462. The colored rendering follows the approach established by rust-lang/rust-analyzer#13848.

Summary

  • render full ty diagnostics with ANSI color and styling when the client opts in
  • negotiate color support separately from fullDiagnosticOutput for rollout compatibility
  • disable terminal hyperlinks in LSP output and cover the behavior under forced hyperlink support

Companion PRs

Test plan

Screen.Recording.2026-06-25.at.19.40.15.mov

@AlexWaygood AlexWaygood added ty Multi-file analysis & type inference server Related to the LSP server labels Jun 25, 2026 — with ChatGPT Codex Connector
@astral-sh-bot

astral-sh-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@AlexWaygood AlexWaygood force-pushed the alex/colored-diagnostics branch from 5bcc458 to a777b40 Compare June 25, 2026 18:38
@astral-sh-bot

astral-sh-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood marked this pull request as ready for review June 25, 2026 18:45
@AlexWaygood AlexWaygood requested review from a team as code owners June 25, 2026 18:45
@astral-sh-bot astral-sh-bot Bot requested a review from MichaReiser June 25, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server Related to the LSP server ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant