Document colored diagnostic output#3858
Merged
Merged
Conversation
This was referenced Jun 25, 2026
sharkdp
approved these changes
Jun 26, 2026
AlexWaygood
added a commit
to astral-sh/ty-vscode
that referenced
this pull request
Jun 26, 2026
## Context This builds on the original **Click for full diagnostic** feature implemented in [astral-sh/ruff#26269](astral-sh/ruff#26269) and [#462](#462). The colored rendering follows the approach established by [rust-lang/rust-analyzer#13848](rust-lang/rust-analyzer#13848). ## Summary - advertise support for colored full diagnostic output - strip ANSI sequences from the virtual document and recreate their styles with VS Code decorations - support named terminal colors, 256-color palette entries, truecolor, and text decorations ## Companion PRs - [astral-sh/ruff#26384](astral-sh/ruff#26384) - [astral-sh/ty#3858](astral-sh/ty#3858) ## Test plan https://github.com/user-attachments/assets/36638263-fe48-4ba7-8abe-95db353f1257
AlexWaygood
added a commit
to astral-sh/ruff
that referenced
this pull request
Jun 26, 2026
## Context This builds on the original **Click for full diagnostic** feature implemented in [#26269](#26269) and [astral-sh/ty-vscode#462](astral-sh/ty-vscode#462). The colored rendering follows the approach established by [rust-lang/rust-analyzer#13848](rust-lang/rust-analyzer#13848). ## Summary - render full ty diagnostics with ANSI color and styling when the client opts in - negotiate color support separately from `fullDiagnosticOutput` for rollout compatibility - disable terminal hyperlinks in LSP output and cover the behavior under forced hyperlink support ## Companion PRs - [astral-sh/ty-vscode#463](astral-sh/ty-vscode#463) - [astral-sh/ty#3858](astral-sh/ty#3858) ## Test plan https://github.com/user-attachments/assets/dc7e7538-ae2b-4870-9e9b-f59943ee804a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This builds on the original Click for full diagnostic feature implemented in astral-sh/ruff#26269 and astral-sh/ty-vscode#462. The colored rendering follows the approach established by rust-lang/rust-analyzer#13848.
Summary
Explain that
fullDiagnosticOutputcan include ANSI colour codes and clients are expected to be able to handle thisCompanion PRs