Switch isEmpty() to .isPresent() for Optionals Type #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
previously approved these changes
Oct 29, 2024
harrryr
force-pushed
the
fix-java-8-error
branch
2 times, most recently
from
97549dc
to
0d85227
Compare
harrryr
changed the title
harrryr
force-pushed
the
fix-java-8-error
branch
2 times, most recently
from
6566ff5
to
eddf39a
Compare
harrryr
force-pushed
the
fix-java-8-error
branch
from
eddf39a
to
f8a8fa9
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=============================================
- Coverage 85.71% 71.99% -13.73%
- Complexity 19 278 +259
=============================================
Files 3 21 +18
Lines 49 989 +940
Branches 5 144 +139
=============================================
+ Hits 42 712 +670
- Misses 3 233 +230
- Partials 4 44 +40 ☔ View full report in Codecov by Sentry. |
harrryr
changed the title
mxiamxia
approved these changes
Oct 30, 2024
Merged
bjrara
added a commit
that referenced
this pull request
Oct 31, 2024
*Description of changes:* 1. [Switch isEmpty() to .isPresent() for Optionals Type #939](#939) 1. [Comment out E2E Operator Test #940](#940) 1. [Add Application Signals runtime metrics #892](#892) 1. [Update Dockerfile for corretto-slim build #924](#924) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Michael He <[email protected]> Co-authored-by: Ping Xiang <[email protected]> Co-authored-by: Reno Seo <[email protected]> Co-authored-by: Harry <[email protected]> Co-authored-by: Min Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Main-build Enablement E2E tests started failing starting from this PR. It was due to the usage of
isEmpty()for Optional datatypes, which is available only from Java 11Description of changes:
Change .isEmpty() to .isPresent() for optional types
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.