Skip to content

Conversation

@fabidick22
Copy link

Issue #, if available:

Description of changes:
This enhancement allows users to configure custom domain names (e.g., images.example.com) for their CloudFront distribution by providing domain names and an ACM certificate ARN through CDK context variables.

Note: I'm not sure if this feature is in the roadmap, but I find it useful for customizing the solution. Feel free to reject this PR if you don't think it's necessary or if it doesn't align with the project's direction.

Changes

  • Add support for customDomainNames and acmCertificateArn CDK context parameters
  • Add new CloudFormation outputs for configured custom domains and certificate ARN

Checklist

  • 👋 I have added unit tests for all code changes.
  • [ x ] 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant