Skip to content

feat(v8): add support for custom domain in ImageProcessingDistribution #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(v8): add support for custom domain in ImageProcessingDistribution #621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 57 additions & 7 deletions source/constructs/lib/v8/stacks/image-processing-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
NestedStack,
NestedStackProps,
} from "aws-cdk-lib";
import * as acm from "aws-cdk-lib/aws-certificatemanager";
import * as cloudfront from "aws-cdk-lib/aws-cloudfront";
import * as origins from "aws-cdk-lib/aws-cloudfront-origins";
import { TableV2 } from "aws-cdk-lib/aws-dynamodb";
Expand Down Expand Up @@ -113,6 +114,8 @@ export class ImageProcessingStack extends NestedStack {
let loggingBucket: s3.Bucket | undefined;
let ditCachePolicy: cloudfront.CachePolicy | undefined;
let ditFunction: cloudfront.Function | undefined;
let configuredDomainNames: string[] | undefined;
let configuredCertificate: acm.ICertificate | undefined;

if (!isDevMode) {
loggingBucket = new s3.Bucket(this, "LoggingBucket", {
Expand Down Expand Up @@ -211,9 +214,41 @@ export class ImageProcessingStack extends NestedStack {
},
});

// Get custom domain configuration from CDK context
// Note: Must use CDK context (not CloudFormation parameters) because
// domain names and certificate need to be set at synthesis time
const contextDomainNames = this.node.tryGetContext("customDomainNames");
const contextCertificateArn = this.node.tryGetContext("acmCertificateArn");

let domainNames: string[] | undefined;
let certificate: acm.ICertificate | undefined;

if (contextCertificateArn && contextDomainNames) {
// Parse domain names (can be string or array)
let domainsStr: string;
if (Array.isArray(contextDomainNames)) {
domainsStr = contextDomainNames.join(",");
} else {
domainsStr = contextDomainNames;
}

// Parse comma-separated domains and trim whitespace
const domains = domainsStr.split(",").map(d => d.trim()).filter(d => d.length > 0);

if (domains.length > 0) {
domainNames = domains;
certificate = acm.Certificate.fromCertificateArn(this, "CustomDomainCertificate", contextCertificateArn);

configuredDomainNames = domains;
configuredCertificate = certificate;
}
}

distribution = new cloudfront.Distribution(this, "ImageProcessingDistribution", {
comment: `Image Handler Distribution for Dynamic Image Transformation - ${deploymentMode} mode`,
priceClass: cloudfront.PriceClass.PRICE_CLASS_ALL,
domainNames,
certificate,
defaultBehavior: {
origin: vpcOrigin!,
viewerProtocolPolicy: cloudfront.ViewerProtocolPolicy.REDIRECT_TO_HTTPS,
Expand Down Expand Up @@ -253,13 +288,16 @@ export class ImageProcessingStack extends NestedStack {
});

// Add CFN Guard suppression for CloudFront Distribution TLS version requirement
addCfnGuardSuppressRules(cfnDistribution, [
{
id: "CLOUDFRONT_MINIMUM_PROTOCOL_VERSION_RULE",
reason:
"Not creating custom certificate and using the default CloudFront certificate that doesn't use TLS 1.2",
},
]);
// Only suppress when NOT using a custom certificate
if (!certificate) {
addCfnGuardSuppressRules(cfnDistribution, [
{
id: "CLOUDFRONT_MINIMUM_PROTOCOL_VERSION_RULE",
reason:
"Not creating custom certificate and using the default CloudFront certificate that doesn't use TLS 1.2",
},
]);
}
}

new Utility(this, "UtilityLambda", {
Expand Down Expand Up @@ -372,6 +410,18 @@ export class ImageProcessingStack extends NestedStack {
value: distribution.distributionDomainName,
description: "CloudFront distribution domain name for accessing the image processing service",
});

if (configuredDomainNames && configuredDomainNames.length > 0 && configuredCertificate) {
new CfnOutput(this, "ConfiguredCustomDomains", {
value: configuredDomainNames.join(", "),
description: "Custom domain names configured for the CloudFront distribution",
});

new CfnOutput(this, "ConfiguredCertificateArn", {
value: configuredCertificate.certificateArn,
description: "ACM certificate ARN used for custom domain names",
});
}
}

if (isDevMode) {
Expand Down